Conversation
- Initialize go.mod module. - Fix Authorization header format (use space instead of comma after OAuth). - Implement custom RFC 3986 encoding (Encode spaces as %20). - Add comprehensive tests for parameter encoding and signature generation. - Update README.md with complete usage example. - Add GoDoc comments to exported symbols.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR addresses the request to complete the documentation, add automated testing, and update dependencies.
Key changes:
go.mod.readme.mdwith a working, copy-pasteable example.gosm.go.gosm_test.gowith tests for parameter encoding and HMAC signature generation.OAuth(wasOAuth,).url.QueryEscapewith a customEscapefunction to ensure RFC 3986 compliance (specifically encoding spaces as%20instead of+), which is required for valid OAuth 1.0a signatures.PR created automatically by Jules for task 1142845251606126184 started by @arran4