-
Notifications
You must be signed in to change notification settings - Fork 20
Add CustomModifier trait to simplify custom modifier implementation #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ProgrammingPirates
wants to merge
18
commits into
armanbilge:main
Choose a base branch
from
ProgrammingPirates:feature/custom-modifier-trait
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add CustomModifier trait to simplify custom modifier implementation #460
ProgrammingPirates
wants to merge
18
commits into
armanbilge:main
from
ProgrammingPirates:feature/custom-modifier-trait
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add CustomModifier[F, E] trait for easier custom modifier creation - Automatically derive Modifier[F, E, CustomModifier[F, E]] typeclass instance - Add sync helper method for simple synchronous operations - Include comprehensive tests demonstrating various use cases - Add documentation with examples and migration guide - Provide example code showing the improvement over manual typeclass implementation Fixes armanbilge#203
- Remove problematic example file that was causing compilation errors - Fix import ordering in test file to match scalafmt rules - Simplify typeclass instance implementation for CustomModifier
- Add CustomModifierCompilationTest to verify typeclass instance works - Test both direct usage and HTML DSL integration - Ensures the Modifier[F, E, CustomModifier[F, E]] instance is properly derived
- Fix long method signatures by breaking them into multiple lines - Ensure all lines are under 96 character limit - Apply proper formatting for typeclass instances and method definitions - Fix formatting for private method signatures and complex type annotations
Author
|
@armanbilge why failed ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses issue #203 by introducing a
CustomModifiertrait that makes implementing custom modifiers much easier and more intuitive.Problem
The current typeclass encoding for custom modifiers is verbose and not straightforward to understand:
Solution
Added a
CustomModifier[F, E]trait that provides a simpler API:Changes
CustomModifier[F, E]trait with automatic typeclass derivationsynchelper method for simple synchronous operationsBenefits
giveninstances manuallyTesting
All tests pass and demonstrate:
Fixes #203