Skip to content

Add support for GNU/Hurd #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

Add support for GNU/Hurd #120

merged 1 commit into from
Oct 25, 2024

Conversation

@pinotree
Copy link
Contributor

@pinotree pinotree commented Oct 19, 2024

  • add a new Platform item for it, and use it explicitly
  • use the unix module, since it provides all the needed bits
  • tweak the unix module for what is supported by Hurd, mostly following what Linux does and using an own UtsName (according to the utsname implementation in GNU libc)

@pinotree pinotree force-pushed the hurd branch 2 times, most recently from 2cf5c5b to fe7e7ca Compare October 19, 2024 20:57
AldaronLau
AldaronLau previously approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@AldaronLau AldaronLau left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR! Looks good, just one minor thing should be changed before releasing

@AldaronLau AldaronLau added this to the 1.6.0 milestone Oct 25, 2024
@pinotree
Add support for GNU/Hurd
95b5431 
- add a new Platform item for it, and use it explicitly
- use the unix module, since it provides all the needed bits
- tweak the unix module for what is supported by Hurd, mostly following
  what Linux does and using an own UtsName (according to the utsname
  implementation in GNU libc)
@AldaronLau AldaronLau enabled auto-merge October 25, 2024 03:35
@AldaronLau AldaronLau added this pull request to the merge queue Oct 25, 2024
Merged via the queue into ardaku:v1 with commit a24087e Oct 25, 2024
64 checks passed
@pinotree pinotree deleted the hurd branch October 25, 2024 03:40
@pinotree
Copy link
Contributor Author

pinotree commented Oct 25, 2024

Thanks for merging this!

What about the v2 branch? Should I submit the same PR to that branch as well, or will the changes be integrated there at some point?

@AldaronLau
Copy link
Member

AldaronLau commented Oct 25, 2024

Thanks for merging this!

Of course, thanks for the PR!

What about the v2 branch? Should I submit the same PR to that branch as well, or will the changes be integrated there at some point?

The v2 branch is currently behind on a bunch of commits, currently trying to figure out the best way to manage sharing changes between the two branches. These changes will be integrated there once I get back to working on 2.0

@pinotree
Copy link
Contributor Author

pinotree commented Oct 25, 2024

The v2 branch is currently behind on a bunch of commits, currently trying to figure out the best way to manage sharing changes between the two branches. These changes will be integrated there once I get back to working on 2.0

Thanks for the explanation; feel free to poke me here in case you think it would be helpful for me to send this PR to v2.

AldaronLau pushed a commit that referenced this pull request Nov 13, 2024
@pinotree @AldaronLau
Add support for GNU/Hurd (#120)
a848c23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AldaronLau AldaronLau AldaronLau left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.6.0

Development

Successfully merging this pull request may close these issues.

2 participants

@pinotree @AldaronLau