Skip to content

Ensure deletes worker iterates over all schedules #5842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christyjacob4 merged 1 commit into from
Jul 20, 2023
Merged

Ensure deletes worker iterates over all schedules #5842

christyjacob4 merged 1 commit into from
Jul 20, 2023

Conversation

@stnguyen90
Copy link
Contributor

@stnguyen90 stnguyen90 commented Jul 19, 2023 •
edited
Loading

What does this PR do?

listByGroup() didn't have any pagination queries so it was getting stuck in an infinite loop.

Test Plan

TBD

Related PRs and Issues

None

Checklist

  • Have you read the Contributing Guidelines on issues?
  • If the PR includes a change to an API's metadata (desc, label, params, etc.), does it also include updated API specs and example docs?

@stnguyen90 stnguyen90 marked this pull request as ready for review July 19, 2023 01:34
@stnguyen90 stnguyen90 changed the title Fix a bug where the delete worker wasn't iterating over schedules Ensure deletes worker iterates over all schedules Jul 19, 2023
@christyjacob4 christyjacob4 merged commit b11fb72 into feat-db-pools-master Jul 20, 2023
@stnguyen90 stnguyen90 deleted the fix-delete-schedules branch July 20, 2023 07:32
This was referenced Aug 1, 2023
Closed
Closed
@stnguyen90 stnguyen90 mentioned this pull request Nov 3, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christyjacob4 christyjacob4 christyjacob4 approved these changes

@Meldiron Meldiron Awaiting requested review from Meldiron

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stnguyen90 @christyjacob4