Lookup groups using group->gr_mem even if getgrouplist() failed #5613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getgrouplist() iterate on each group, searching if the user is included, while group->gr_mem iterated on user list for the target group. In some case the former method can miss the result while the later will succeed. This is the case for OpenLDAP dyngroup, where the group members are automatically generated on group search. Searching by group member gives no result, while searching the member of a given groups is fine.
Collaborator
|
Will consider this, although I am definitely not super happy about the inconsistency... |
michaelrsweet
added a commit
that referenced
this pull request
Jul 16, 2019
michaelrsweet
added a commit
that referenced
this pull request
Jul 16, 2019
Collaborator
|
I reworked this change to move the membership list check up front, followed by the getgrouplist check. We already have the list of usernames that are members, so this made more sense than checking after the (semi-expensive) getgrouplist check. [master 3c27d2a] Always check the group membership list (Issue #5613) [branch-2.2 666d076] Always check the group membership list (Issue #5613) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getgrouplist() iterate on each group, searching if the user
is included, while group->gr_mem iterated on user list for
the target group. In some case the former method can miss
the result while the later will succeed. This is the case
for OpenLDAP dyngroup, where the group members are automatically
generated on group search. Searching by group member gives no
result, while searching the member of a given groups is fine.