Improved failure messages for MSQCompactionRunner. #18787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include the first failure message in the task status itself, so it is not necessary to fetch task logs to see the error message. Also, don't log the entire task JSON for failed subtasks. It is logged once when a subtask is initially run, and that's enough.
cryptoe
reviewed
Dec 1, 2025
| final TaskStatus eachResult = eachTask.run(toolbox); | ||
| if (!eachResult.isSuccess()) { | ||
| if (task.isReady(toolbox.getTaskActionClient())) { | ||
| log.info("Running MSQControllerTask[%d]: %s", taskCnt, json); |
Contributor
There was a problem hiding this comment.
Nit: It seems kind of weird that the MSQControllerTask[%d] is not the the task id but the taskcnt.
Should be rename this to something like
"Running MSQCompaction task number[%d] with payload : %s"
Contributor
Author
There was a problem hiding this comment.
Updated them all to be like MSQControllerTask number[%d].
| if (!taskStatus.isSuccess()) { | ||
| failCnt++; | ||
| log.warn("Failed to run MSQControllerTask: [%s].\nTrying the next MSQControllerTask.", json); | ||
| log.warn("Failed to run MSQControllerTask[%d]: %s", taskCnt, taskStatus.getErrorMsg()); |
Contributor
There was a problem hiding this comment.
Similar task number comment here.
cryptoe
approved these changes
Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the first failure message in the task status itself, so it is not necessary to fetch task logs to see the error message.
Also, don't log the entire task JSON for failed subtasks. It is logged once when a subtask is initially run, and that's enough.