Fix K8S task runner log and doc #18105
Conversation
| | `druid.indexer.runner.labels` | `JsonObject` | Additional labels you want to add to peon pod. | `{}` | No | | ||
| | `druid.indexer.runner.annotations` | `JsonObject` | Additional annotations you want to add to peon pod. | `{}` | No | | ||
| | `druid.indexer.runner.peonMonitors` | `JsonArray` | Overrides `druid.monitoring.monitors`. Use this property if you don't want to inherit monitors from the Overlord. | `[]` | No | | ||
| | Property | Possible Values | Description | Default | Required | |
There was a problem hiding this comment.
The formatting followed in Druid docs is to avoid unnecessary spaces.
So a table typically looks like this:
|Column 1|Column 2|Column 3|
|--------|--------|--------|
|Value 11|Value 12|Long value 13|
|This is a much longer value 21|v22|v23|
I would advise either reverting the formatting changes here (to keep this patch focused on the code change) or sticking to the above format.
I think in the long term, we should also explore the idea of standard formatting for tables etc in docs. I don't think there is any checkstyle or some kind of lint checker that is currently run as a part of docs CI.
There was a problem hiding this comment.
Many markdown editors automatically format tables. It's better to solve the format problem in the doc soon.
...lord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/KubernetesPeonClient.java
Outdated
Show resolved
Hide resolved
...lord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/KubernetesPeonClient.java
Outdated
Show resolved
Hide resolved
|
|
||
| if (result == null) { | ||
| throw new IllegalStateException("K8s pod for the task [%s] appeared and disappeared. It can happen if the task was canceled"); | ||
| throw new ISE(StringUtils.format("K8s pod for the task [%s] appeared and disappeared. It can happen if the task was canceled", task.getId())); |
There was a problem hiding this comment.
I think ISE already takes a format string with args, we need not explicitly use StringUtils.format.
…rg/apache/druid/k8s/overlord/common/KubernetesPeonClient.java Co-authored-by: Kashif Faraz <[email protected]>
…rg/apache/druid/k8s/overlord/common/KubernetesPeonClient.java Co-authored-by: Kashif Faraz <[email protected]>
...lord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/KubernetesPeonClient.java
Outdated
Show resolved
Hide resolved
…rg/apache/druid/k8s/overlord/common/KubernetesPeonClient.java Co-authored-by: Kashif Faraz <[email protected]>
Description
This PR has: