Skip to content

[Dataflow Streaming] Change GrpcGetDataStream to backoff requests that have been cancelled. #36475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −10
Open

[Dataflow Streaming] Change GrpcGetDataStream to backoff requests that have been cancelled. #36475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions .../java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcGetDataStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ final class GrpcGetDataStream

static final FluentBackoff BACK_OFF_FACTORY =
FluentBackoff.DEFAULT
.withInitialBackoff(Duration.millis(10))
.withInitialBackoff(Duration.millis(1))
.withMaxBackoff(Duration.standardSeconds(10));

/**
Expand Down Expand Up @@ -439,23 +439,24 @@ private <ResponseT> ResponseT issueRequest(QueuedRequest request, ParseFn<Respon
try {
queueRequestAndWait(request);
return parseFn.parse(request.getResponseStream());
} catch (AppendableInputStream.InvalidInputStreamStateException | CancellationException e) {
} catch (CancellationException e) {
throwIfShutdown(request, e);
if (!(e instanceof CancellationException)) {
throw e;
}
} catch (AppendableInputStream.InvalidInputStreamStateException e) {
throwIfShutdown(request, e);
throw e;
} catch (IOException e) {
LOG.error("Parsing GetData response failed: ", e);
try {
BackOffUtils.next(Sleeper.DEFAULT, backoff);
} catch (InterruptedException ie) {
Thread.currentThread().interrupt();
}
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
throwIfShutdown(request, e);
throw new RuntimeException(e);
}
// In all cases we are going to retry, perform some backoff
try {
BackOffUtils.next(Sleeper.DEFAULT, backoff);
} catch (InterruptedException ie) {
Thread.currentThread().interrupt();
}
}
}

Expand Down
Loading