-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Fix ValueError affecting XVR tests #35766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @A1K28, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've addressed a ValueError
that was affecting XVR tests, specifically related to the parsing of timestamp strings. The core of the problem was datetime.fromisoformat
failing when timestamps had fractional seconds with fewer than the expected six digits. My changes introduce a robust method to normalize these timestamp strings by padding the fractional seconds with zeros, ensuring they are always in a format that datetime.fromisoformat
can successfully process. This makes the example pipeline more resilient to variations in timestamp data precision.
Highlights
- Timestamp Parsing Fix: I've implemented a fix for
ValueError
that occurs whendatetime.fromisoformat
attempts to parse timestamp strings with fractional seconds that are not exactly six digits long. This is a common issue when dealing with varying precision in timestamp data. - Robust Timestamp Normalization: The solution involves using a regular expression to detect and pad the fractional second part of the timestamp string with trailing zeros, ensuring it always has six digits (microseconds) before being passed to
datetime.fromisoformat
. This makes the parsing robust to different input precisions. - Broad Application in Example Pipeline: This fix has been applied to both the main
timestamp
field and all derivedpickup_datetime
fields (year, month, day, weekday, hour) within thestreaming_taxifare_prediction.yaml
example, ensuring consistent and error-free date-time extraction.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
R: @Abacn |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Fixes #31418
Fixes #30602
Fixes #30601
Fixes #30517
Successful workflow (Flink): https://github.com/A1K28/beam/actions/runs/16682909834
Successful workflow (Samza): https://github.com/A1K28/beam/actions/runs/16682918253
Successful workflow (Spark3): https://github.com/A1K28/beam/actions/runs/16682927799
Successful workflow (DirectRunner): https://github.com/A1K28/beam/actions/runs/16682929064
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.