Skip to content

Conversation

tarun-google
Copy link
Contributor

@tarun-google tarun-google commented Jul 1, 2025

This PR Fixes issue #34966

Allows users to pass Iceberg Table properties which are used while creating a table. For more information on table properties please visit https://iceberg.apache.org/docs/latest/configuration/#table-properties

This PR only addresses providing table-properties through beam-sdks-java-io-iceberg. It does not handle providing properties through Beam SQL

@tarun-google tarun-google force-pushed the iceberg_table_properties branch from c561272 to a7b77ad Compare July 1, 2025 18:24
@tarun-google tarun-google changed the title [IcebergIO] Create tables with a Iceberg Table Properties [IcebergIO] Create tables with Iceberg Table Properties Jul 1, 2025
Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tarun-google, this looks great! just one comment

@ahmedabu98
Copy link
Contributor

Also no need to manually update the docs, just run ./gradlew generateExternalTransformsConfig and it will generate it with appropriate styling.

@tarun-google tarun-google marked this pull request as ready for review July 1, 2025 19:39
Copy link
Contributor

github-actions bot commented Jul 1, 2025

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@tarun-google tarun-google force-pushed the iceberg_table_properties branch from 0efb25b to 5458a46 Compare July 1, 2025 20:49
@tarun-google tarun-google requested a review from ahmedabu98 July 1, 2025 21:27
@tarun-google
Copy link
Contributor Author

"Run Java PreCommit"

@tarun-google
Copy link
Contributor Author

Run Java PreCommit

@tarun-google tarun-google reopened this Jul 1, 2025
Copy link
Contributor

@ahmedabu98 ahmedabu98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahmedabu98
Copy link
Contributor

Congrats on your first PR @tarun-google!

@ahmedabu98 ahmedabu98 merged commit 011970d into apache:master Jul 2, 2025
33 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants