-
Notifications
You must be signed in to change notification settings - Fork 4.4k
[IcebergIO] Create tables with Iceberg Table Properties #35496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IcebergIO] Create tables with Iceberg Table Properties #35496
Conversation
45ed005
to
c561272
Compare
c561272
to
a7b77ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tarun-google, this looks great! just one comment
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergCatalogConfig.java
Outdated
Show resolved
Hide resolved
Also no need to manually update the docs, just run |
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
0efb25b
to
5458a46
Compare
"Run Java PreCommit" |
Run Java PreCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Congrats on your first PR @tarun-google! |
This PR Fixes issue #34966
Allows users to pass Iceberg Table properties which are used while creating a table. For more information on table properties please visit https://iceberg.apache.org/docs/latest/configuration/#table-properties
This PR only addresses providing table-properties through beam-sdks-java-io-iceberg. It does not handle providing properties through Beam SQL