Skip to content

Correctly auto-enable prism for some pipelines #34921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2025
Merged

Correctly auto-enable prism for some pipelines #34921

merged 3 commits into from
May 14, 2025

Conversation

damccorm
Copy link
Contributor

@damccorm damccorm commented May 12, 2025 •
edited
Loading

Right now, when switching between direct runner implementations, Prism checks pr.state.is_terminal() and if it throws it will fallback to a different runner implementation. This means that Prism is never auto-enabled. This fixes that problem.

Part of #34549 - I initially targeted the whole thing in #34612, but that is proving difficult and needs to be chunked up somehow.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@damccorm damccorm changed the title Correctly auto-enable prism for any pipelines Correctly auto-enable prism for some pipelines May 13, 2025
@damccorm damccorm mentioned this pull request May 13, 2025
Merged
3 tasks
@damccorm damccorm marked this pull request as ready for review May 13, 2025 19:53
@damccorm
Copy link
Contributor Author

R: @robertwb since you have a related effort in #34721 - this at least gets us some of the way there, I'm hoping to start burning down other tests/issues once this change is in.

@github-actions GitHub Actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@damccorm damccorm requested a review from liferoad May 14, 2025 14:54
@liferoad liferoad merged commit 5f4efb1 into master May 14, 2025
91 checks passed
@damccorm damccorm deleted the users/damccorm/prismFallbackLogic branch May 14, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liferoad liferoad liferoad approved these changes

Assignees
No one assigned
Labels