Skip to content

[Dataflow Streaming] Change GrpcGetDataStream to backoff requests that have been cancelled. #36475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Dataflow Streaming] Change GrpcGetDataStream to backoff requests that have been cancelled. #36475

wants to merge 1 commit into from
+11 −10

Conversation

scwhittle
Copy link
Contributor

Not doing this means that if requests are sent batched and the stream fails for some reason related to batching (like duplicated work token) all of the requests are retried at the same time and are likely to rebatch the same way. Adding backoff means the requests will be sent differently.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@scwhittle
Copy link
Contributor Author

R: @arunpandianp

@gemini-code-assist Gemini Code Assist
Copy link
Contributor

Summary of Changes

Hello @scwhittle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the GrpcGetDataStream in Dataflow Streaming by implementing a more comprehensive backoff strategy for cancelled requests and other retriable exceptions. This change aims to prevent scenarios where batched requests, upon cancellation, would immediately retry and potentially re-encounter the same failure conditions, leading to a cycle of unproductive retries. By introducing a unified backoff mechanism, the system can space out retries, allowing for better recovery and more efficient resource utilization.

Highlights

  • Backoff for Cancellation Exceptions: The GrpcGetDataStream now explicitly applies a backoff strategy when requests are cancelled, preventing immediate, repeated failures of batched requests that might re-batch in the same problematic way.
  • Unified Backoff Logic: The backoff mechanism has been refactored to be applied consistently across all retriable exceptions within the issueRequest method, ensuring a more robust and predictable retry strategy.
  • Reduced Initial Backoff Duration: The initial backoff duration for FluentBackoff has been decreased from 10 milliseconds to 1 millisecond, potentially allowing for quicker initial retries while still benefiting from exponential backoff.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@github-actions GitHub Actions
Copy link
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arunpandianp arunpandianp arunpandianp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dataflow runners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scwhittle @arunpandianp