fix: Use airflow conf in supervisor for task_success_overtime #53342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
approved these changes
Jul 14, 2025
3b2ece0 to
5f18da9
Compare
|
Also extended the warning message to clearly state which setting is responsible for this kill. |
5f18da9 to
3d41ee9
Compare
|
Test failure is unrelated, some server error on provider test. |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2025
(cherry picked from commit afb2e8a) Co-authored-by: Kacper Muda <[email protected]>
Backport successfully created: v3-0-test
|
Programmer-RD-AI
pushed a commit
to Programmer-RD-AI/airflow
that referenced
this pull request
Jul 15, 2025
kaxil
pushed a commit
that referenced
this pull request
Jul 18, 2025
…#53351) (cherry picked from commit afb2e8a) Co-authored-by: Kacper Muda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Airflow config for task_success_overtime was not actually used, instead a default value of 20 seconds was always applied.
This PR removes a TODO and uses the actual airflow config value. I think this is a bug and should be backported to 3.0.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.