Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
• Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: [email protected]
  Slack: https://s.apache.org/airflow-slack

Although there are no config changes with this the self-signed certificate does need subject alt names set:

openssl req -x509 -newkey rsa:4096 -keyout key.pem -out cert.pem -sha256 -days 3650 -nodes \
-subj "CN=<common name>" \
-addext "subjectAltName=DNS:localhost,DNS:airflow-apiserver"

For the certificate to be accepted (this is based on the quick start docker-compose.yaml). As well as the cert being passed to curl using curl --cacert for the apiserver health check plus changing the url from HTTP to HTTPS.

I think this should be documented somewhere but I am unsure where the best place would be. It is supposed to be non-production use but some instances may require the additional security even for this.

You can run the pre-commit hook locally—this will automatically fix any static check issues

Also, it would be great to add a unit test covering it. @Subham-KRLX -> you said you can collaborate, so maybe adding a unit test as PR to the PR might be a good idea :)

Hi @danieldean I have added a unit test for the new SSL certificate config logic in the API client and confirmed that it passes locally
I have opened a PR with this test .

Hi @danieldean I have added a unit test for the new SSL certificate config logic in the API client and confirmed that it passes locally I have opened a PR with this test .

This appears to be based on a different logic contained within the client to that in this PR?

I think you need to use my branch as a base and make a test based on that if possible.

I have rebased my branch on top of yours and updated the base of my PR accordingly. The unit test now aligns with your changes. Please let me know if you need any adjustments or additional coverage.

I have rebased my branch on top of yours and updated the base of my PR accordingly. The unit test now aligns with your changes. Please let me know if you need any adjustments or additional coverage.

I am unsure what has happened but there appears to be something wrong with this. You have different code in the client.py and other changes pulling in many approvers.

I have built an image from my branch so I can get on with things. It is here if it is of any use to anyone: https://hub.docker.com/r/danieldean/airflow-test

@danieldean ,Could you please clarify which specific changes or tests you want me to update so everything aligns? I will make the adjustments accordingly.

I see the MyPy checks are failing due to type errors involving direct assignment to ssl.SSLContext methods and some type mismatches in task-sdk/tests/task_sdk/init.py. If you can share how you had prefer the SSL method mocking or type annotations to be adjusted . Just let me know if you want me to try specific fixes or take a look at detailed errors to help move this forward.

I have done some reading on testing and revised my methods. I believe static checks and tests all now pass. Just a short how to on this and all is hopefully done.

Rebased it. I think the mypy error is already fixed in main.

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

🎉

@potiuk excellent, thanks for your help. I will take a look at adding to the documentation over the coming week.