Fix config templates type #50792
Merged
Fix config templates type #50792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f5f64e7 to
c4add24
Compare
pierrejeambrun
approved these changes
May 26, 2025
Lee-W
reviewed
May 26, 2025
kaxil
reviewed
May 27, 2025
kaxil
approved these changes
May 27, 2025
There was a problem hiding this comment.
This doesn't affect any runtime behavior since we use conf.getint , conf.getboolean etc. This is purely for displaying in https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html
c4add24 to
73f4dc8
Compare
phanikumv
approved these changes
May 27, 2025
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 8bee3fb v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
|
Thanks for all reviews. |
pierrejeambrun
pushed a commit
to astronomer/airflow
that referenced
this pull request
May 28, 2025
(cherry picked from commit 8bee3fb)
|
Backport PR: |
pierrejeambrun
added a commit
that referenced
this pull request
May 28, 2025
(cherry picked from commit 8bee3fb) Co-authored-by: Guan Ming(Wesley) Chiu <[email protected]>
kaxil
pushed a commit
that referenced
this pull request
Jun 3, 2025
(cherry picked from commit 8bee3fb) Co-authored-by: Guan Ming(Wesley) Chiu <[email protected]>
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
jose-lehmkuhl
pushed a commit
to jose-lehmkuhl/airflow
that referenced
this pull request
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When migrating my local cfg to newest one, I found there are some type error in config template
cc @pierrejeambrun
How
Update them to correct type
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.