Resolve and validate AWS Connection parameters in wrapper #25256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6900359 to
dda3fe7
Compare
dda3fe7 to
79279cf
Compare
vincbeck
approved these changes
Jul 25, 2022
ferruzzi
reviewed
Jul 25, 2022
potiuk
approved these changes
Jul 26, 2022
This was referenced Jul 27, 2022
This was referenced Aug 10, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate class which help resolve and validate AWS connection parameters.
Currently, might for historical reason, connections properties validate/read/resolve/construct in
BaseSessionFactoryandAwsGenericHookin different methods.This changes would help to make changes/deprecate in AWS Connection settings easier than now - need to make changes in one place, rather tried to found in multiple places.
Also it should make easier tests Connections configuration relates.
WDYT? @o-nikolas @ferruzzi
Note:
BaseSessionFactorystill use connection configs for SAML and Web Federation, I have to plan remove this in the further PRs