Skip to content

SSHHook: Saving new host keys as described in docs #25979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2022
Merged

SSHHook: Saving new host keys as described in docs #25979

merged 1 commit into from
Aug 27, 2022

Conversation

doiken
Copy link
Contributor

@doiken doiken commented Aug 26, 2022

When no_host_key_check is true, new host keys are not added.

from airflow import DAG
from airflow.operators.python import PythonOperator
from airflow.providers.ssh.hooks.ssh import SSHHook
from airflow.utils.dates import days_ago

with DAG(dag_id="example_python", schedule_interval=None, start_date=days_ago(2)) as dag:
    def f():
        hook = SSHHook(ssh_conn_id="ssh_default")
        hook.exec_ssh_client_command(hook.get_conn(), "grep localhost ~/.ssh/known_hosts", False, None, None)
        # [2022-08-26, 09:52:15 UTC] {ssh.py:467} INFO - Running command: grep localhost ~/.ssh/known_hosts
        # [2022-08-26, 09:52:15 UTC] {python.py:171} INFO - Done. Returned value was: None

    t = PythonOperator(task_id="example", python_callable=f)

I hope that it works as the docs described bellow.
https://airflow.apache.org/docs/apache-airflow-providers-ssh/stable/connections/ssh.html

no_host_key_check ... Default is true, ssh will automatically add new host keys to the user known hosts files.

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 26, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk merged commit 2f26da7 into apache:main Aug 27, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 27, 2022

Awesome work, congrats on your first merged pull request!

@doiken doiken deleted the save-new-host-keys branch August 29, 2022 02:30
@potiuk potiuk mentioned this pull request Sep 28, 2022
Closed
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

Assignees

No one assigned

Labels

area:providers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@doiken @potiuk