Athena and EMR operator max_retries mix-up fix #25971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some failures. |
uranusjr
reviewed
Aug 28, 2022
…ion warning to inform users about naming change. Raise Exception if values of `max_tries` does not match value of `max_polling_attempts`.
cfe584a to
b13070a
Compare
potiuk
approved these changes
Sep 11, 2022
89 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue regarding a mix up of variable names. The solution proposed changes the variable name
max_retirestomax_polling_attempts. Both names are currently accepted, but ifmax_triesis used, the user is shown a deprecation warning. Internally, the operators only usemax_polling_attempts. If both are passed, but their values are not equal, an Exception is thrown.closes: #22381
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.