Cache cleanup #427
Merged
Cache cleanup #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 25, 2020 16:35
|
if we are changing the plugin name, we should consider changing the package name as well. |
jijisv
reviewed
Aug 25, 2020
|
|
||
|
|
||
| @Slf4j | ||
| public class TransientElasticacheDataConnection<V> implements DistributedCacheManager<V> { | ||
| public class ElasticacheConnection<K, V> implements DistributedCache<K, V> { |
There was a problem hiding this comment.
MemcachedCacheImpl may be a better name IMO.
jijisv
reviewed
Aug 25, 2020
| try { | ||
| log.info("Creating Memcached Data connection for elasticache cluster: {}", hostname); | ||
| return new TransientElasticacheDataConnection(createMemcachedClient(), retryAfterSecs, maxRetries); | ||
| return new ElasticacheConnection(createMemcachedClient(), retryAfterSecs, maxRetries); |
There was a problem hiding this comment.
DistributedCache and its impl support generics and we are loosing the type info here..
added 2 commits
August 26, 2020 11:26
jijisv
approved these changes
Aug 27, 2020
added 2 commits
August 27, 2020 12:06
jijisv
reviewed
Aug 27, 2020
| @@ -9,6 +9,6 @@ | |||
|
|
|||
| @Override | |||
| public Set<Class> springClasses() { | |||
| return SetX.of(ConfigureElasticache.class); | |||
| return SetX.of(ElasticacheConfig.class); | |||
There was a problem hiding this comment.
I guess we will have to add DistributedCacheFactory.class also here..
jijisv
reviewed
Aug 27, 2020
| public <K, V> DistributedCache<K, V> create() { | ||
| try { | ||
| log.info("Creating Memcached Data connection for elasticache cluster: {}", config.getHostname()); | ||
| return new MemcachedCacheImpl(createMemcachedClient(), config.getRetryAfterSecs(), config.getMaxRetries()); |
There was a problem hiding this comment.
I guess
return new MemcachedCacheImpl<K, V>(createMemcachedClient(), ...There was a problem hiding this comment.
IIRC the compiler can deduce the types <K, V> from the return type.
There was a problem hiding this comment.
besides, the IDE suggests it's not relevant
jijisv
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.