Skip to content

Conversation

@OliverNChalk
Copy link

Problem

  • Currently, to track in-flight senders the poh thread reads 3 separate AtomicU64s. This is quite difficult to reason about and we are seeing panics that strongly imply something here is racing when a bank reset occurs.

Summary of Changes

  • Use a single AtomicU64 to track in flight sends to make it easier to reason about the absence of races.

Fixes #9002

@OliverNChalk OliverNChalk force-pushed the fix/poh-recorder-panic branch 4 times, most recently from 89bd284 to aba762f Compare November 12, 2025 00:34
@OliverNChalk OliverNChalk force-pushed the fix/poh-recorder-panic branch from aba762f to 3964ab1 Compare November 12, 2025 01:39
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 98.70130% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.9%. Comparing base (47fd923) to head (3964ab1).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #9030     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         862      862             
  Lines      326717   326755     +38     
=========================================
- Hits       267674   267668      -6     
- Misses      59043    59087     +44     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ftv68 paniced with PohRecorder::record failed: MaxHeightReached

2 participants