Skip to content

docs: 优化链接跳转自定义标记文档 close #2914 #2918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wjgogogo merged 1 commit into from
Oct 8, 2024
Merged

docs: 优化链接跳转自定义标记文档 close #2914 #2918

wjgogogo merged 1 commit into from
Oct 8, 2024

Conversation

@lijinke666
Copy link
Member

@lijinke666 lijinke666 commented Sep 30, 2024

👀 PR includes

🔧 Chore

  • Test case
  • Docs / demos update
  • CI / workflow
  • Release version
  • Other ()

📝 Description

🖼️ Screenshot

Before After
❌ ✅

🔗 Related issue link

close #2914

🔍 Self-Check before the merge

  • Add or update relevant docs.
  • Add or update relevant demos.
  • Add or update test case.
  • Add or update relevant TypeScript definitions.

@vercel
Copy link

vercel bot commented Sep 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
antvis-s2 ❌ Failed (Inspect) Sep 30, 2024 9:49am

@github-actions github-actions bot added pr(documentation) documentation next 2.0-next 版本的问题 labels Sep 30, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2024

Size Change: 0 B

Total Size: 329 kB

ℹ️ View Unchanged
Filename Size
./packages/s2-core/dist/index.min.js 229 kB
./packages/s2-core/dist/style.min.css 388 B
./packages/s2-react/dist/index.min.js 70.9 kB
./packages/s2-react/dist/style.min.css 3.88 kB
./packages/s2-vue/dist/index.min.js 22.9 kB
./packages/s2-vue/dist/style.min.css 1.97 kB

compressed-size-action

@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2024

你好, @lijinke666 CI 执行失败, 请点击 [Details] 按钮查看, 并根据日志修复。

Hello, @lijinke666 CI run failed, please click the [Details] button for detailed log information and fix it.

@github-actions github-actions bot added the 🚨 test failed 单元测试挂了 label Sep 30, 2024
@lijinke666 lijinke666 linked an issue Sep 30, 2024 that may be closed by this pull request
🐛链接跳转自定义标记无法同步获取到node的belogsCell #2914
Closed
5 tasks
@github-actions github-actions bot removed the 🚨 test failed 单元测试挂了 label Oct 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.80%. Comparing base (ecdc9c8) to head (dc96a66).
Report is 441 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #2918      +/-   ##
==========================================
+ Coverage   75.77%   80.80%   +5.03%     
==========================================
  Files         257      180      -77     
  Lines       11994    10418    -1576     
  Branches     2464     2361     -103     
==========================================
- Hits         9088     8418     -670     
+ Misses       1398      554     -844     
+ Partials     1508     1446      -62

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjgogogo wjgogogo merged commit 44ed5f8 into next Oct 8, 2024
@wjgogogo wjgogogo deleted the docs-2914 branch October 8, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjgogogo wjgogogo wjgogogo approved these changes

@wuhaiyang wuhaiyang Awaiting requested review from wuhaiyang

Assignees

@lijinke666 lijinke666

Labels

next 2.0-next 版本的问题 pr(documentation) documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛链接跳转自定义标记无法同步获取到node的belogsCell

4 participants

@lijinke666 @codecov-commenter @wjgogogo