Skip to content

Conversation

@ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented May 2, 2020

Harden Molecule own testing by treating any runtime warnings as errors.

@ssbarnea ssbarnea added the test Improvement to quality assurance: CI/CD, testing, building label May 2, 2020
@ssbarnea ssbarnea force-pushed the fix/warns-as-errors branch from 208195c to 6e696a5 Compare May 4, 2020 14:43
@ssbarnea ssbarnea self-assigned this May 4, 2020
@ssbarnea ssbarnea marked this pull request as ready for review May 4, 2020 14:51
@ssbarnea ssbarnea force-pushed the fix/warns-as-errors branch from 6e696a5 to 6a61032 Compare May 5, 2020 12:00
@ericsysmin
Copy link
Contributor

So, at this point, we're safe to assume and mandate molecule supports Python 3.6+ only, and are no longer testing on Python <3.6?

@ssbarnea
Copy link
Member Author

ssbarnea commented May 6, 2020

@ericsysmin That is correct, in fact these are only leftovers from the main removal.

@ssbarnea ssbarnea force-pushed the fix/warns-as-errors branch from 6a61032 to fc2ee54 Compare May 10, 2020 11:43
Harden Molecule own testing by treating any runtime warnings
as errors.
@ssbarnea ssbarnea force-pushed the fix/warns-as-errors branch from fc2ee54 to 98ab818 Compare May 11, 2020 09:07
@ssbarnea
Copy link
Member Author

recheck

@ssbarnea ssbarnea merged commit 79db66a into master Jun 19, 2020
@ssbarnea ssbarnea deleted the fix/warns-as-errors branch June 19, 2020 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Improvement to quality assurance: CI/CD, testing, building

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants