Skip to content

Add collection-aware scenario discovery and creation #4499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cidrblock merged 8 commits into from
Aug 8, 2025
Merged

Add collection-aware scenario discovery and creation #4499

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bd636c7
Squashed all commits from PR #4499
cidrblock Aug 6, 2025
b6f57f7
Use ImmediateExit
cidrblock Aug 6, 2025
74fa8dc
Test updates
cidrblock Aug 6, 2025
795b7fa
Fix ImmediateExit usage in list command
cidrblock Aug 6, 2025
1e455c1
Add comprehensive unit tests for lookup_config_file function
cidrblock Aug 6, 2025
e0a97d5
Fix ruff linting errors in lookup_config_file tests
cidrblock Aug 6, 2025
a4b6da3
Fix test mocks to match find_vcs_root function signature
cidrblock Aug 6, 2025
fa850ce
Add noqa comments to suppress ARG005 warnings in test mocks
cidrblock Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix ImmediateExit usage in list command 
- Provide both message and code arguments as required by constructor
- Add proper exception chaining with 'from exc'
- Document raised exception in docstring

Fixes linting errors: B904, DOC501, DOC503, E1120, call-arg, arg-type
  • Loading branch information
@cidrblock
cidrblock committed Aug 6, 2025
commit 795b7fa412024cbd2206de70aab071078926f0a8
5 changes: 4 additions & 1 deletion src/molecule/command/list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ def list_(ctx: click.Context) -> None: # pragma: no cover

Args:
ctx: Click context object holding commandline arguments.

Raises:
ImmediateExit: If scenario configuration fails.
"""
args = ctx.obj.get("args")
subcommand = base._get_subcommand(__name__) # noqa: SLF001
Expand All @@ -81,7 +84,7 @@ def list_(ctx: click.Context) -> None: # pragma: no cover
try:
configs = base.get_configs(args, command_args)
except ScenarioFailureError as exc:
raise ImmediateExit(exc.code)
raise ImmediateExit(str(exc), exc.code) from exc

s = scenarios.Scenarios(
configs,
Expand Down