Use metric prefixes and limit to 3 significant figures #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I love it! |
This was referenced Jun 21, 2023
Closed
|
Using kilo-seconds seem a bit strange, especially going from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the result of a spike into looking for ways to show a set amount of sigfigs.
Instead of scientific notation, I decided to try metric prefixes (T, G, M, K, etc) since it fits in with how we already display max RSS & durations.
I feel like I landed on something that looks good and communicates the info pretty well imo.
The central alignment of each of the columns comes trivially from the comptime-known sigfig limit.
There's no pressure to accept this PR if this isn't how you'd like things to be displayed, just want to make that clear.
Closes #28
Related to #24
Status quo for comparison: