Skip to content

print usage text on no or unrecognized args and add -d shorthand for duration #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 17, 2023
Merged

print usage text on no or unrecognized args and add -d shorthand for duration #21

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
73efeaa
print usage text more
xdBronch Jun 16, 2023
faef4f2
add duration -d shorthand
xdBronch Jun 16, 2023
a65b196
check lack of args properly and handle when '-d' isnt given another a…
xdBronch Jun 16, 2023
c6748aa
Merge branch 'main' into main
xdBronch Jun 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/main.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const usage_text =
\\Compares the performance of the provided commands.
\\
\\Options:
\\ --duration <ms> (default: 5000) how long to repeatedly sample each command
\\ -d, --duration <ms> (default: 5000) how long to repeatedly sample each command
\\
;

Expand Down Expand Up @@ -98,8 +98,12 @@ pub fn main() !void {
} else if (std.mem.eql(u8, arg, "-h") or std.mem.eql(u8, arg, "--help")) {
try stdout.writeAll(usage_text);
return std.process.cleanExit();
} else if (std.mem.eql(u8, arg, "--duration")) {
} else if (std.mem.eql(u8, arg, "-d") or std.mem.eql(u8, arg, "--duration")) {
arg_i += 1;
if (arg_i >= args.len) {
std.debug.print("'{s}' requires an additional argument.\n{s}", .{ arg, usage_text });
std.process.exit(1);
}
const next = args[arg_i];
const max_ms = std.fmt.parseInt(u64, next, 10) catch |err| {
std.debug.print("unable to parse --duration argument '{s}': {s}\n", .{
Expand All @@ -109,15 +113,21 @@ pub fn main() !void {
};
max_nano_seconds = std.time.ns_per_ms * max_ms;
} else {
std.debug.print("unrecognized argument: '{s}'\n", .{arg});
std.debug.print("unrecognized argument: '{s}'\n{s}", .{ arg, usage_text });
std.process.exit(1);
}
}

if (commands.items.len == 0) {
try stdout.writeAll(usage_text);
std.process.exit(1);
}

var progress: std.Progress = .{};
const root_node = progress.start("poop", commands.items.len);
defer root_node.end();


var perf_fds = [1]fd_t{-1} ** perf_measurements.len;
var samples_buf: [10000]Sample = undefined;

Expand Down