Fixed CMake project's include directory linkage when added via add_subdirectory #306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When linking project by
add_subdirectory(libsoundio_dir)
project's include directories are not being propagated to linking project thus giving compilation errors. This can be fixed if inCMakeLists.txt
:include_directores
will be changed to:and moved after
add_library
line. In order not to open too much interface to linking projects following line can be added afteradd_library
instead of changing:Adding
include
directory to root of project and moving public includes there adds more protection to includes: