[BUGFIX] Correct cache lifetime calculation for pages

saschanowak · lolli42 · commit ad3d93a04917 · 2025-12-08T18:53:58.000+01:00
Page cache lifetime is calculated differently from other records. The current implementation in ContentObjectRenderer doesn’t account for this difference, resulting in incorrect lifetime values. It is ok to skip lifetime calculation for pages table records in ContentObjectRenderer, details are added as inline code comment. Resolves: #107097 Releases: main, 13.4 Change-Id: I565b46c6efd7cfab148dc51187e08dd22d46a0ef Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/92026 Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Garvin Hicking <garvin@hick.ing> Reviewed-by: Sascha Nowak <typo3@saschanowak.me> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Tested-by: Sascha Nowak <typo3@saschanowak.me> Reviewed-by: Garvin Hicking <garvin@hick.ing> Tested-by: core-ci <typo3@b13.com>
diff --git a/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php b/typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php
@@ -516,7 +516,14 @@ public function start($data, $table = ''): void
         $this->eventDispatcher->dispatch(new AfterContentObjectRendererInitializedEvent($this));
 
         $autoTagging = $this->features->isFeatureEnabled('frontend.cache.autoTagging');
-        if (is_array($this->data) && $this->currentRecord !== '' && $autoTagging) {
+        if (is_array($this->data) && $this->currentRecord !== '' && $autoTagging && $this->table !== 'pages') {
+            // Page lifetime for the requested page is calculated in RequestHandler, taking
+            // cache_period and TypoScript into account.
+            // When start() is called here, it can be the requested page record, which is handled
+            // already, OR it is a page record *used* on this page, for instance from a menu rendering.
+            // In the latter case, we do *not* want to reduce the lifetime of the rendered page down
+            // to the cache_period of that content related page record. We can thus skip 'pages' records
+            // here altogether.
             $lifetime = $this->cacheLifetimeCalculator->calculateLifetimeForRow($this->table, $this->data);
             $cacheTags = [
                 sprintf('%s_%s', $this->table, ($this->data['uid'] ?? 0)),
