[TASK] Add symfony/console 7.4.1 compatibility to CliCommandTest

garvinhicking · garvinhicking · commit 23dc2ea3d9c3 · 2025-12-08T18:36:28.000+01:00
With Symfony 7.4.1 a change was made on how interactive input was evaluated, and no longer failing on the CliCommandTest of TYPO3. This change adapts the test to not expect a failure, but instead accept a "success" exit code, by removing the interaction argument and using a "dry-run". The modification also revealed that passing args was missing a command substitution placeholder, which is now added the calls of: - referenceindex:update (--check) - cleanup:localprocessedfiles (-v) Resolves: #108423 Releases: main Change-Id: Ia302486782a2e151b4127af1c0fed075fa6aaf15 Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/92038 Tested-by: Sven Liebert <mail@sven-liebert.de> Tested-by: Lina Wolf <112@linawolf.de> Tested-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by: Lina Wolf <112@linawolf.de> Reviewed-by: Simon Schaufelberger <simonschaufi+typo3@gmail.com> Reviewed-by: Sven Liebert <mail@sven-liebert.de> Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de> Tested-by: Garvin Hicking <garvin@hick.ing> Tested-by: Christian Kuhn <lolli@schwarzbu.ch> Reviewed-by: Garvin Hicking <garvin@hick.ing> Tested-by: core-ci <typo3@b13.com> Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
diff --git a/typo3/sysext/core/Tests/Functional/Command/CliCommandTest.php b/typo3/sysext/core/Tests/Functional/Command/CliCommandTest.php
@@ -63,7 +63,7 @@ public static function commandTestDataProvider(): array
         return [
             ['command' => 'styleguide:generate tca', 'args' => [], 'expectedExitCode' => 0],
             ['command' => 'styleguide:generate frontend', 'args' => [], 'expectedExitCode' => 0],
-            ['command' => 'cleanup:localprocessedfiles', 'args' => ['-v'], 'expectedExitCode' => 0],
+            ['command' => 'cleanup:localprocessedfiles %s', 'args' => ['-v'], 'expectedExitCode' => 0],
             ['command' => 'cache:flush', 'args' => [], 'expectedExitCode' => 0],
             ['command' => 'cache:warmup', 'args' => [], 'expectedExitCode' => 0],
             ['command' => 'cleanup:flexforms', 'args' => [], 'expectedExitCode' => 0],
@@ -79,19 +79,19 @@ public static function commandTestDataProvider(): array
             ['command' => 'mailer:spool:send', 'args' => [], 'expectedExitCode' => 1],
             ['command' => 'redirects:checkintegrity', 'args' => [], 'expectedExitCode' => 0],
             ['command' => 'redirects:cleanup', 'args' => [], 'expectedExitCode' => 0],
-            ['command' => 'referenceindex:update', 'args' => ['--check'], 'expectedExitCode' => 0],
+            ['command' => 'referenceindex:update %s', 'args' => ['--check'], 'expectedExitCode' => 0],
             ['command' => 'scheduler:run', 'args' => [], 'expectedExitCode' => 0],
             ['command' => 'site:list', 'args' => [], 'expectedExitCode' => 0],
             ['command' => 'site:show show-me', 'args' => [], 'expectedExitCode' => 0],
             ['command' => 'syslog:list', 'args' => [], 'expectedExitCode' => 0],
             ['command' => 'upgrade:list', 'args' => [], 'expectedExitCode' => 0],
+            ['command' => 'install:password:set %s %s', 'args' => ['--no-interaction', '--dry-run'], 'expectedExitCode' => 0],
             // supported shells
             ['command' => 'completion bash', 'args' => [], 'expectedExitCode' => 0],
             ['command' => 'completion fish', 'args' => [], 'expectedExitCode' => 0],
             ['command' => 'completion zsh', 'args' => [], 'expectedExitCode' => 0],
             // unsupported shell (not detected)
             ['command' => 'completion', 'args' => [], 'expectedExitCode' => 2],
-            ['command' => 'install:password:set', 'args' => [], 'expectedExitCode' => 1],
         ];
     }
 
