Skip to content

Conversation

@andrrrl
Copy link
Contributor

@andrrrl andrrrl commented Jul 21, 2020

Ahora los hints soportan types (info, success, danger, etc), por ejemplo:

  • <div hint="Hola" hintType="success"></div>

El cual internamente asigna un type al <plex-icon>

  • De esta manera es posible usarlos como alertas para novedades
  • Además se creó un mixin genérico en sass para generar estilos de types, restaría actualizar los usos de types en los distintos compontentes (y similar con sizes)

@andrrrl andrrrl mentioned this pull request Jul 21, 2020
@andrrrl andrrrl requested review from JSantarelli and liquid36 July 21, 2020 18:56
Copy link
Contributor

@JSantarelli JSantarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Los types funcionan de la manera esperada.

@andrrrl andrrrl merged commit 2c9d924 into master Aug 5, 2020
@andrrrl andrrrl deleted the hint-types branch August 5, 2020 18:33
@liquid36
Copy link
Contributor

liquid36 commented Aug 7, 2020

🎉 This PR is included in version 6.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants