Skip to content

fix: just-compare crash on some objects #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: just-compare crash on some objects #575

wants to merge 1 commit into from

Conversation

Sec-ant
Copy link

@Sec-ant Sec-ant commented Jan 26, 2024 •
edited
Loading

  • objects with keys shadowing hasOwnProperty
  • objects with no prototypes

@Sec-ant
fix: just-compare crash on some objects
6821948 
- objects with keys shadowing `hasOwnProperty`
- objects with no prototypes
@Sec-ant Sec-ant force-pushed the shadowed-has-own-property branch from c2c27f5 to 6821948 Compare January 26, 2024 07:04
@Sec-ant Sec-ant changed the title fix: crash on objects with keys shadowing hasOwnProperty fix: just-compare crash on some objects Jan 26, 2024
@clintonpowell
Copy link

@angus-c Is anybody maintaining this repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@clintonpowell clintonpowell clintonpowell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sec-ant @clintonpowell