Branch cordova plugin #515
Conversation
There was a problem hiding this comment.
Overall looks good. Currently the majority of plugins live outside the core repository as it became too much to maintain all in one repo. For example, I have no experience with branch or cordova so I will be unable to maintain support for this. Would you be able to post this code to angulartics/angulartics-branch-cordova if I create this repository?
| var deferred = $q.defer(); | ||
| var deviceReady = false; | ||
|
|
||
| window.addEventListener('deviceReady', function () { |
There was a problem hiding this comment.
use $window for testing purposes
| deferred.resolve(); | ||
| }); | ||
|
|
||
| setTimeout(function () { |
There was a problem hiding this comment.
use $timeout for testing purposes
|
Yes, I would be happy to make the changes recommended above and submit them to a new repo that you create. Please let me know when |
|
Thanks @giltotherescue these have been created and you are a collaborator on all 3 |
|
Sorry, just got super busy. I can work on it sometime next week. Haven't On Wednesday, October 5, 2016, Tim Elfelt [email protected] wrote:
|
|
Hi Tim, I'm so sorry that I never got around to implementing this. I would
very much like to contribute, however my startup is pretty much all
consuming.
That said, I do have quite a few Angulartics cordova implementations in
production that I would like to share (now incl. FB and Firebase). I am
attaching the source files in a zip in case you happen to have time to
implement. All of these are running successfully in production in my mobile
app.
https://cl.ly/341R363I2g18
Hope this helps!
On Wed, Oct 5, 2016 at 12:28 PM, Gil Hildebrand <[email protected]>
wrote:
… Sorry, just got super busy. I can work on it sometime next week. Haven't
forgotten about it. If you'd like to help please feel free.
On Wednesday, October 5, 2016, Tim Elfelt ***@***.***>
wrote:
> @giltotherescue <https://github.com/giltotherescue> need any help moving
> this over?
> https://github.com/angulartics/angulartics-branch-cordova
> https://github.com/angulartics/angulartics-mixpanel-cordova
> https://github.com/angulartics/angulartics-intercom-cordova
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#515 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAWqMv5MMAsB75rcq8-df3C6YIfspm3Vks5qw9u4gaJpZM4KHO4T>
> .
>
|
I have similar plugins for both Mixpanel Cordova and Intercom Cordova. Before I submit the others, would someone mind reviewing this and letting me know if there is anything I need to add or improve upon in this PR? I am successfully using this plugin within my app.