Skip to content

refactor(zone.js): remove unused jasmine globalerror monkey patch. #63077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JeanMeche wants to merge 1 commit into from
Closed

refactor(zone.js): remove unused jasmine globalerror monkey patch. #63077

JeanMeche wants to merge 1 commit into from
+0 −66

Conversation

@JeanMeche
Copy link
Member

@JeanMeche JeanMeche commented Aug 10, 2025

This is for testing purposes for now. See discussion on the related issue.

fixes #63072

@angular-robot angular-robot bot added the area: zones Issues related to zone.js label Aug 10, 2025
@ngbot ngbot bot added this to the Backlog milestone Aug 10, 2025
@atscott
Copy link
Contributor

atscott commented Aug 10, 2025

Also here

angular/packages/zone.js/test/node_bluebird_entry_point.init.ts

Line 51 in 660444f

(jasmine as any).GlobalErrors = function () {

@JeanMeche JeanMeche force-pushed the zone/jasmine-monkeypatch branch from b53a6c5 to a0f5e03 Compare August 10, 2025 23:55
@JeanMeche
refactor(zone.js): remove unused jasmine globalerror monkey patching.
e9e6156 
This is for testing purposes for now. See discussion on the related issue.

fixes angular#63072
@JeanMeche JeanMeche force-pushed the zone/jasmine-monkeypatch branch from a0f5e03 to e9e6156 Compare August 10, 2025 23:58
@JeanMeche JeanMeche mentioned this pull request Aug 11, 2025
Closed
@JeanMeche
Copy link
Member Author

JeanMeche commented Aug 11, 2025

Passing TGP

@JeanMeche JeanMeche changed the title refactor(zone.js): remove unused jasmine globalerror monkey patching. refactor(zone.js): remove unused jasmine globalerror monkey patch. Aug 11, 2025
@atscott atscott marked this pull request as ready for review August 11, 2025 23:21
@pullapprove pullapprove bot requested a review from kirjs August 11, 2025 23:21
@atscott atscott added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release action: merge The PR is ready for merge by the caretaker labels Aug 11, 2025
@ngbot
Copy link

ngbot bot commented Aug 11, 2025

I see that you just added the action: merge label, but the following checks are still failing:
    failure status "mergeability" is failing
    pending 1 pending code review

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken main, please try rebasing to main and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@atscott atscott removed the request for review from kirjs August 11, 2025 23:36
atscott pushed a commit that referenced this pull request Aug 11, 2025
@JeanMeche @atscott
refactor(zone.js): remove unused jasmine globalerror monkey patching. (…
e6c84a4 
…#63077)

This is for testing purposes for now. See discussion on the related issue.

fixes #63072

PR Close #63077
@atscott
Copy link
Contributor

atscott commented Aug 11, 2025

This PR was merged into the repository by commit 9aef481.

The changes were merged into the following branches: main, 20.1.x, 20.2.x

atscott pushed a commit that referenced this pull request Aug 11, 2025
@JeanMeche @atscott
refactor(zone.js): remove unused jasmine globalerror monkey patching. (…
b38c43b 
…#63077)

This is for testing purposes for now. See discussion on the related issue.

fixes #63072

PR Close #63077
@atscott atscott closed this in 9aef481 Aug 11, 2025
@JeanMeche JeanMeche deleted the zone/jasmine-monkeypatch branch August 29, 2025 00:43
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 29, 2025

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@atscott atscott atscott approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: zones Issues related to zone.js target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

zone.js monkey patching of Jasmine's GlobalErrors is a no-op, and would break Jasmine if it wasn't

2 participants

@JeanMeche @atscott