feat(zone.js): Update to the simpler Async Stack Tagging v2 API #46958

victorporof · 2022-07-25T09:08:36Z

Signed-off-by: Victor Porof [email protected]

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

Chrome DevTools is planning on dropping the experimental flag for the new async stack tagging API and enabling this feature by default on the console object. As part of this, the API has been improved to be more robust. More details in the chromium bug and in the V8 implementation.

Does this PR introduce a breaking change?

Yes
No

victorporof · 2022-07-25T09:09:27Z

@JiaLiPassion @mgechev PTAL!

JiaLiPassion · 2022-07-25T17:04:34Z

packages/zone.js/lib/zone-spec/async-stack-tagging.ts

In the previous version, scheduleAsyncTask has the 2nd parameter which tells console the task is period or not,

if it is not period task, then finishAsyncTask can only be called once.

if it is period task such as eventTask or setInterval, finishAsyncTask can be called multiple times.

So in the v2 API, this spec has been changed?

Yes, in the new API, tasks can always be recurring (aka, they can run multiple times). Consumers of the API don't need to specify this beforehand, nor do they need to cancel the tasks anymore. More details here.

Signed-off-by: Victor Porof <[email protected]>

victorporof · 2022-07-26T09:10:20Z

Last minute change: we renamed console.scheduleTask to console.createTask. Updated the PR to reflect that.

JiaLiPassion · 2022-07-26T11:31:43Z

@victorporof , thank you for the explaination, LGTM.

AndrewKushnir · 2022-08-01T21:23:45Z

@victorporof could you please run a TGP with those changes to make sure there are no failures in g3? Thank you.

victorporof · 2022-08-03T14:37:49Z

@AndrewKushnir I'm not sure what that means :) What button should I press and where can I find it? 😄

AndrewKushnir · 2022-08-03T17:56:16Z

@victorporof no worries, I'll take care of it and let you know if there are any failures.

AndrewKushnir · 2022-08-04T02:18:14Z

Global Presubmit.

victorporof · 2022-08-04T07:10:37Z

Global Presubmit.

Thank you @AndrewKushnir! I see a few failures there, are they related to this PR?

AndrewKushnir · 2022-08-04T16:40:22Z

@victorporof test failures turned out to be flakes, so this PR is now ready for merge. Thank you.

AndrewKushnir · 2022-08-04T16:40:57Z

Merge-assistance: LGTM from Jia should be enough to proceed with this change. TGP is "green".

dylhunn · 2022-08-04T21:25:37Z

This PR was merged into the repository by commit f23232f.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [zone.js](https://github.com/angular/angular) ([changelog](https://github.com/angular/angular/blob/master/packages/zone.js/CHANGELOG.md)) | dependencies | patch | [`0.11.7` -> `0.11.8`](https://renovatebot.com/diffs/npm/zone.js/0.11.7/0.11.8) | --- ### Release Notes <details> <summary>angular/angular</summary> ### [`v0.11.8`](https://github.com/angular/angular/blob/HEAD/packages/zone.js/CHANGELOG.md#0118-httpsgithubcomangularangularcomparezonejs-0117zonejs-0118-2022-08-08) [Compare Source](angular/angular@zone.js-0.11.7...zone.js-0.11.8) ##### Features - **zone.js:** Update to the simpler Async Stack Tagging v2 API ([#46958](angular/angular#46958)) ([f23232f](angular/angular@f23232f)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1504 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>

angular-automatic-lock-bot · 2022-09-04T16:06:29Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

pullapprove bot requested a review from JiaLiPassion July 25, 2022 09:08

JiaLiPassion reviewed Jul 25, 2022

View reviewed changes

mgechev approved these changes Jul 25, 2022

View reviewed changes

jessicajaniuk added the area: zones Issues related to zone.js label Jul 25, 2022

ngbot bot added this to the Backlog milestone Jul 25, 2022

feat(zone.js): Update to the simpler Async Stack Tagging v2 API

da9d273

Signed-off-by: Victor Porof <[email protected]>

victorporof force-pushed the astv2 branch from a210857 to da9d273 Compare July 26, 2022 09:09

angular-robot bot requested a review from mgechev July 26, 2022 09:10

JiaLiPassion approved these changes Jul 26, 2022

View reviewed changes

JiaLiPassion added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Jul 26, 2022

AndrewKushnir added the action: global presubmit The PR is in need of a google3 global presubmit label Aug 1, 2022

victorporof mentioned this pull request Aug 3, 2022

feat: Add Async Stack Tagging API support #46693

Closed

12 tasks

AndrewKushnir self-assigned this Aug 3, 2022

AndrewKushnir removed the action: global presubmit The PR is in need of a google3 global presubmit label Aug 4, 2022

AndrewKushnir added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Aug 4, 2022

dylhunn closed this in f23232f Aug 4, 2022

sync-by-unito bot mentioned this pull request Sep 1, 2022

build(deps): bump zone.js from 0.11.4 to 0.11.8 numbersprotocol/capture-cam#2003

Closed

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2022

feat(zone.js): Update to the simpler Async Stack Tagging v2 API #46958

feat(zone.js): Update to the simpler Async Stack Tagging v2 API #46958

Uh oh!

Conversation

victorporof commented Jul 25, 2022

PR Checklist

PR Type

Does this PR introduce a breaking change?

Uh oh!

victorporof commented Jul 25, 2022

Uh oh!

JiaLiPassion Jul 25, 2022

Choose a reason for hiding this comment

Uh oh!

victorporof Jul 26, 2022

Choose a reason for hiding this comment

Uh oh!

victorporof commented Jul 26, 2022

Uh oh!

JiaLiPassion commented Jul 26, 2022

Uh oh!

AndrewKushnir commented Aug 1, 2022

Uh oh!

victorporof commented Aug 3, 2022

Uh oh!

AndrewKushnir commented Aug 3, 2022

Uh oh!

AndrewKushnir commented Aug 4, 2022

Uh oh!

victorporof commented Aug 4, 2022

Uh oh!

AndrewKushnir commented Aug 4, 2022

Uh oh!

AndrewKushnir commented Aug 4, 2022

Uh oh!

dylhunn commented Aug 4, 2022

Uh oh!

angular-automatic-lock-bot bot commented Sep 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants