Skip to content

Bump golangci-lint to 1.45.0 #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 22, 2022
Merged

Bump golangci-lint to 1.45.0 #909

merged 3 commits into from
Mar 22, 2022

Conversation

wagoodman
Copy link
Contributor

@wagoodman wagoodman commented Mar 22, 2022 •
edited
Loading

Given that golangci/golangci-lint#2438 has been merged (🎉 🌮 ) we can now keep our linter on the same go version we are releasing with (this PR removes the go1.17 related CI jobs for static analysis).

@wagoodman wagoodman requested a review from a team March 22, 2022 14:16
@wagoodman wagoodman self-assigned this Mar 22, 2022
@github-actions
Copy link

Benchmark Test Results

Benchmark results from the latest changes vs base branch 
name                                                       old time/op    new time/op    delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2              1.44ms ± 1%    1.36ms ± 1%  -5.72%  (p=0.008 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2            3.64ms ± 3%    3.53ms ±13%    ~     (p=0.151 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2    1.17ms ± 1%    1.10ms ± 1%  -6.02%  (p=0.008 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         796µs ± 7%     740µs ± 1%  -7.05%  (p=0.008 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     940µs ± 4%     880µs ± 1%  -6.37%  (p=0.008 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      813µs ± 4%     785µs ± 1%    ~     (p=0.421 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      14.7ms ± 2%    14.5ms ± 2%    ~     (p=0.222 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.43ms ± 2%    1.38ms ± 3%  -3.22%  (p=0.016 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2          2.44µs ± 4%    2.35µs ± 2%    ~     (p=0.056 n=5+5)

name                                                       old alloc/op   new alloc/op   delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               182kB ± 0%     182kB ± 0%    ~     (p=0.690 n=5+5)
ImagePackageCatalogers/python-package-cataloger-2             891kB ± 0%     893kB ± 0%  +0.19%  (p=0.016 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     194kB ± 0%     194kB ± 0%    ~     (p=0.421 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         138kB ± 0%     138kB ± 0%  -0.19%  (p=0.016 n=5+5)
ImagePackageCatalogers/dpkgdb-cataloger-2                     173kB ± 0%     173kB ± 0%    ~     (p=0.690 n=5+5)
ImagePackageCatalogers/rpmdb-cataloger-2                      162kB ± 0%     162kB ± 0%    ~     (p=1.000 n=5+5)
ImagePackageCatalogers/java-cataloger-2                      3.18MB ± 0%    3.18MB ± 0%    ~     (p=0.690 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                     1.23MB ± 0%    1.23MB ± 0%    ~     (p=0.421 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            608B ± 0%      608B ± 0%    ~     (all equal)

name                                                       old allocs/op  new allocs/op  delta
ImagePackageCatalogers/ruby-gemspec-cataloger-2               3.67k ± 0%     3.67k ± 0%    ~     (all equal)
ImagePackageCatalogers/python-package-cataloger-2             14.9k ± 0%     14.9k ± 0%  +0.02%  (p=0.024 n=5+5)
ImagePackageCatalogers/php-composer-installed-cataloger-2     4.98k ± 0%     4.98k ± 0%    ~     (p=0.444 n=5+5)
ImagePackageCatalogers/javascript-package-cataloger-2         2.70k ± 0%     2.70k ± 0%    ~     (all equal)
ImagePackageCatalogers/dpkgdb-cataloger-2                     3.97k ± 0%     3.97k ± 0%    ~     (all equal)
ImagePackageCatalogers/rpmdb-cataloger-2                      3.99k ± 0%     3.99k ± 0%    ~     (all equal)
ImagePackageCatalogers/java-cataloger-2                       51.9k ± 0%     51.9k ± 0%    ~     (p=0.802 n=5+5)
ImagePackageCatalogers/apkdb-cataloger-2                      4.82k ± 0%     4.82k ± 0%    ~     (p=1.000 n=5+5)
ImagePackageCatalogers/go-module-binary-cataloger-2            14.0 ± 0%      14.0 ± 0%    ~     (all equal)

@wagoodman wagoodman merged commit 7f9edf3 into main Mar 22, 2022
@wagoodman wagoodman deleted the bump-linter-for-go-1.18 branch March 22, 2022 15:02
GijsCalis pushed a commit to GijsCalis/syft that referenced this pull request Feb 19, 2024
@wagoodman
Bump golangci-lint to 1.45.0 (anchore#909)
eaeec87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spiffcs spiffcs spiffcs approved these changes

Assignees

@wagoodman wagoodman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wagoodman @spiffcs