fixed dotnet-deps cataloger skip project type by def, fixed #4423 #4436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rez Moss <[email protected]>
Signed-off-by: Rez Moss <[email protected]>
Signed-off-by: Rez Moss <[email protected]>
Signed-off-by: Rez Moss <[email protected]>
Signed-off-by: Rez Moss <[email protected]>
Signed-off-by: Rez Moss <[email protected]>
kzantow
reviewed
Dec 17, 2025
cmd/syft/internal/options/catalog.go
Outdated
Comment on lines
268
to
269
| flags.BoolVarP(&cfg.Dotnet.ExcludeProjectReferences, "dotnet-exclude-project-references", "", | ||
| "exclude packages with type 'project' from deps.json output (default: true)") |
Contributor
There was a problem hiding this comment.
We should probably not add a flag for this, it seems like the right behavior to default and override via configuration or environment variable, if needed.
Contributor
|
One comment about adding a flag, but also I think you need to regenerate a new schema? After that, this looks good to me 👍 |
Signed-off-by: Christopher Phillips <[email protected]>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Christopher Angelo Phillips <[email protected]>
Signed-off-by: Rez Moss <[email protected]>
Signed-off-by: Rez Moss <[email protected]>
Signed-off-by: Rez Moss <[email protected]>
Signed-off-by: Rez Moss <[email protected]>
spiffcs
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed #4423
Type of change
Checklist: