chore: address test flakes #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're seeing this timeout triggered in CI. Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
Otherwise, we'd run tests twice for each PR; once because it was a PR, and once because someone pushed to a branch. Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
wagoodman
approved these changes
Nov 20, 2023
Contributor
wagoodman
left a comment
There was a problem hiding this comment.
mind adding a comment around the timeouts (could link to the PR or a short 1 sentence explanation... or both)?
Signed-off-by: Will Murphy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seem to be a few things happening:
spawn ETXTBSYfrom Node, which means that we tried to exec a file that is also open for writing. I think this is a race condition where one test is running grype while another is installing it.grype: is the filename correct and the file marked as executable? (Like this: https://github.com/anchore/scan-action/actions/runs/6931060595/job/18851984035#step:8:144). I think this is also a race WRT to installing grype.Therefore:
beforeAll, so that when the individual tests run grype, it's already there, so hopefully no one will race to install it.