Skip to content

Conversation

willmurphyscode
Copy link
Contributor

@willmurphyscode willmurphyscode commented Sep 17, 2024

Previously, this function would fall back to legacy behavior if it was looking at a configuration with a single platform CPE. However, the legacy behavior is incorrect for some orderings of the platform and application CPEs, so stop falling back.

TODO:

  • verify that this removal has no other side effects
  • if the old fallback is now unreachable, remove it entirely

westonsteimel
westonsteimel previously approved these changes Sep 17, 2024
@westonsteimel westonsteimel added the bug Something isn't working label Sep 17, 2024
@westonsteimel westonsteimel dismissed their stale review September 17, 2024 14:59

I'm pushing code changes

@westonsteimel westonsteimel marked this pull request as ready for review September 17, 2024 16:03
@westonsteimel westonsteimel requested a review from a team September 17, 2024 16:04
@westonsteimel westonsteimel merged commit cec1ab3 into main Sep 17, 2024
14 checks passed
@westonsteimel westonsteimel deleted the grype-db-platform-cpe-ordering-bug branch September 17, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants