Add GRYPE_DB_EXECUTABLE_PATH support to bypass Go build requirement #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add opt-in env var GRYPE_DB_EXECUTABLE_PATH to allow using pre-built grype-db binaries instead of building from source. This enables easier execution of grype-db-manager in distroless environments without the Go toolchain installed - Uses cross-platform shutil.which() for executable validation - Logs warnings and falls back to source build if path is invalid or not exe - No behavior changes for existing users (opt-in only) - Test coverage added for new branching logic changes Signed-off-by: James Gardner <[email protected]>
b199cf8 to
41a6267
Compare
…n method for cyclomatic complexity linting Signed-off-by: James Gardner <[email protected]>
…ll_grype_db Signed-off-by: James Gardner <[email protected]>
|
The failing stuff in CI was related to cyclomatic complexity (C901), as the number of conditionals in the method already are at the limit. @wagoodman - I am happy to refactor this, but due to this being load bearing think it might be appropriate to add in an exclusion for that rule there. I've gone ahead and added it, but if you'd prefer for me to refactor just let me know! Thanks. |
wagoodman
approved these changes
Oct 6, 2025
|
Thanks @wagoodman ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add opt-in environment variable
GRYPE_DB_EXECUTABLE_PATHto allow using pre-built grype-db binaries instead of building from source. This enables running grype-db-manager in distroless containers or environments without Go toolchain installed.Changes
GRYPE_DB_EXECUTABLE_PATHenvironment variable supportshutil.which()for executable validationUse Case
Useful for CI environments where grype-db binary is already available, eliminating the need for Go toolchain in container images. This does include the same checks, but skips the build / pull if the executable exists.
Testing