Skip to content
This repository was archived by the owner on Jul 10, 2024. It is now read-only.

Add max_images_per_account logic to cli #157

Merged
merged 2 commits into from
Jan 26, 2021
Merged

Add max_images_per_account logic to cli #157

merged 2 commits into from
Jan 26, 2021

Conversation

@dakaneye
Copy link
Contributor

Relates to fix for anchore/anchore-engine#858
Signed-off-by: Samuel Dacanay [email protected]

@dakaneye dakaneye requested review from zburstein and zhill January 26, 2021 02:02
@zburstein
Copy link

@dakaneye @zhill Does functionality for setting the selectors when making an archival rule via the cli need to be added?

@dakaneye
Copy link
Contributor Author

@dakaneye @zhill Does functionality for setting the selectors when making an archival rule via the cli need to be added?

@zburstein are you referring to the exclude selector? The selectors for a basic transition rule are already @click options:

anchore-cli/anchorecli/cli/archives.py

Line 227 in 5710569

@click.option(

@zhill zhill linked an issue Jan 26, 2021 that may be closed by this pull request
Add support for max_images_per_account in analysis-archive commands #154
Closed
zhill
zhill approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@zhill zhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. adding exclusions can be another PR. This looks good for the max_images.

@zburstein
Copy link

@dakaneye Yeah sorry I did mean the exclude selectors

zburstein
zburstein approved these changes Jan 26, 2021
View reviewed changes
Copy link

@zburstein zburstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for max images!

@zhill zhill merged commit e8d6963 into master Jan 26, 2021
@dakaneye dakaneye deleted the max-accounts-archive-impl branch February 9, 2021 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@zhill zhill zhill approved these changes

@zburstein zburstein zburstein approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support for max_images_per_account in analysis-archive commands

4 participants

@dakaneye @zburstein @zhill