Adding excludes to other spring boot dependencies as well #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-rubenstein
approved these changes
Oct 16, 2017
94f828b to
b4b4f4b
Compare
freemabd1
added a commit
that referenced
this pull request
Oct 16, 2017
…-beta (#195) * RW-197 made changes to fix BQ version changes. * RW-197 made changes to fix BQ version changes. * Adding excludes to other spring boot dependencies as well (#194) * Removing deps again * No notifications for non-master branch * RW-197 Removed unused import and renamed methods to reflect return type. * RW-197 made changes to fix BQ version changes. * RW-197 made changes to fix BQ version changes. * RW-197 Removed unused import and renamed methods to reflect return type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As just removing them from starter-web wasn't actually removing them from the dependencies.