Skip to content

Conversation

tarekmamdouh
Copy link
Collaborator

We have Snyk configured which reports new vulnerabilities so we don't need this tool. See issues documented in:
dependency-check/dependency-check-gradle#467

This caused failures in our build for the past few days.
https://app.circleci.com/pipelines/github/all-of-us/workbench/38566/workflows/c67cec56-f5b9-4217-9ccc-452ed761ddff


PR checklist

  • I have included an issue ID or "no ticket" in the PR title as outlined in CONTRIBUTING.md.
  • I have included a risk tag of the form [risk=no|low|moderate|severe] in the PR title as outlined in CONTRIBUTING.md.
  • I have manually tested this change and my testing process is described above.
  • This change includes appropriate automated tests, and I have documented any behavior that cannot be tested with code.
  • I have added explanatory comments where the logic is not obvious.
  • One or more of the following is true:
    • This change is intended to complete a JIRA story, so I have checked that all AC are met for that story.
    • This change fixes a bug, so I have ensured the steps to reproduce are in the Jira ticket or provided above.
    • This change impacts deployment safety (e.g. removing/altering APIs which are in use), so I have documented the impacts in the description.
    • This change includes a new feature flag, so I have created and linked new JIRA tickets to (a) turn on the feature flag and (b) remove it later.
    • This change modifies the UI, so I have taken screenshots or recordings of the new behavior and notified the PO and UX designer in Slack.
    • This change modifies API behavior, so I have run the relevant E2E tests locally because API changes are not covered by our PR checks.
    • None of the above apply to this change.

@yonghaoy
Copy link
Collaborator

The risk level should be higher and we probably need a PD ticket, But this blocking release and has urgency
I will create a PD ticket to explain this

@tarekmamdouh tarekmamdouh merged commit 4b08269 into main Sep 29, 2025
5 checks passed
@tarekmamdouh tarekmamdouh deleted the tarek/dependency-analyzer-debug branch September 29, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants