Skip to content

[risk=low][RW-14706][RW-5107] rm billing_account_type #9227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

[risk=low][RW-14706][RW-5107] rm billing_account_type #9227

merged 1 commit into from
Apr 16, 2025

Conversation

jmthibault79
Copy link
Collaborator

@jmthibault79 jmthibault79 commented Apr 16, 2025 •
edited
Loading

We stopped using this field to determine initial-credits vs. user-provided billing all the way back in 2021, and we now always check whether the billing account name matches the initial-credits account name: #5898

Probably safe to remove it at this point ;-)

Tested by running locally and doing a local reporting snapshot.

PR checklist

  • I have included an issue ID or "no ticket" in the PR title as outlined in CONTRIBUTING.md.
  • I have included a risk tag of the form [risk=no|low|moderate|severe] in the PR title as outlined in CONTRIBUTING.md.
  • I have manually tested this change and my testing process is described above.
  • This change includes appropriate automated tests, and I have documented any behavior that cannot be tested with code.
  • I have added explanatory comments where the logic is not obvious.
  • One or more of the following is true:
    • This change is intended to complete a JIRA story, so I have checked that all AC are met for that story.
    • This change fixes a bug, so I have ensured the steps to reproduce are in the Jira ticket or provided above.
    • This change impacts deployment safety (e.g. removing/altering APIs which are in use), so I have documented the impacts in the description.
    • This change includes a new feature flag, so I have created and linked new JIRA tickets to (a) turn on the feature flag and (b) remove it later.
    • This change modifies the UI, so I have taken screenshots or recordings of the new behavior and notified the PO and UX designer in Slack.
    • This change modifies API behavior, so I have run the relevant E2E tests locally because API changes are not covered by our PR checks.
    • None of the above apply to this change.

Qi77Qi
Qi77Qi approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@Qi77Qi Qi77Qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no code references for this field need to be removed?

@jmthibault79
Copy link
Collaborator Author

That's right. There have been no code references to this field since November 2021.

@jmthibault79 jmthibault79 merged commit 1367dfd into main Apr 16, 2025
5 of 7 checks passed
@jmthibault79 jmthibault79 deleted the joel/rm-billing-type branch April 16, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Qi77Qi Qi77Qi Qi77Qi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmthibault79 @Qi77Qi