Skip to content

Dockerfiles for api + ui server #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2017
Merged

Dockerfiles for api + ui server #9

merged 2 commits into from
Jul 14, 2017

Conversation

jmandel
Copy link
Contributor

@jmandel jmandel commented Jul 14, 2017

No description provided.

@jmandel jmandel requested a review from danqrodney July 14, 2017 00:44
@jmandel jmandel changed the title Get Dockerfile paths right and move gradle into api to match README Dockerfiles for api + ui server Jul 14, 2017
danqrodney
danqrodney approved these changes Jul 14, 2017
View reviewed changes
Copy link
Contributor

@danqrodney danqrodney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@jmandel jmandel merged commit 17c31d9 into master Jul 14, 2017
@jmandel jmandel deleted the jmandel/reconfigure-docker branch July 14, 2017 01:46
@markfickett
Copy link 

+# shared-git-hooks needs this to be a git dir
--
  |   | +RUN git init

I'm confused by this bit. I put the shared hooks directory at the repository root, and shared-git-hooks seems fine with that. It's not ideal that shared-git-hooks comes out of the UI and then applies to both UI and API, but it seems to work OK.

jmthibault79 pushed a commit that referenced this pull request Sep 6, 2023
@calbach
Pull out wboptionsparser to aou/utils (#9)
ea9dcfc
jmthibault79 pushed a commit that referenced this pull request Sep 7, 2023
@calbach @jmthibault79
Pull out wboptionsparser to aou/utils (#9)
96a8d6a
jmthibault79 pushed a commit that referenced this pull request Sep 8, 2023
@calbach @jmthibault79
Pull out wboptionsparser to aou/utils (#9)
382a7cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@danqrodney danqrodney danqrodney approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmandel @markfickett @danqrodney