Sorting #83
Merged
Sorting #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmohs
approved these changes
Aug 21, 2017
| <clr-dg-column [clrDgField]="'cohort.name'" [clrDgSortBy]="cohortNameComparator"> | ||
| Name | ||
| <clr-dg-string-filter [clrDgStringFilter]="cohortNameFilter"></clr-dg-string-filter> | ||
| <clr-dg-string-filter [clrDgStringFilter]="cohortNameFilter" ></clr-dg-string-filter> |
markfickett
reviewed
Aug 29, 2017
| * determine the order that the cohorts loaded into client side memory | ||
| * are displayed. | ||
| */ | ||
| class CohortNameComparator implements Comparator<Cohort> { |
There was a problem hiding this comment.
What would you think of just having a common localeStringComparator used by most of our tables?
There was a problem hiding this comment.
Related: There is some duplication here. Could we have something like HasName and HasDescription interfaces and then get something like:
class DescriptionComparator implements Comparator<HasDescription> {
compare(a: HasDescription, b: HasDescription) {
return a.description.localeCompare(b.description);
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A version of this on the test environment can be found at:
https://brubenst---pr-dot-all-of-us-workbench-test.appspot.com/workspace/namespace/workspace-id