fix for new notebook button being truncated #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SrushtiGangireddy
pushed a commit
that referenced
this pull request
Apr 18, 2018
freemabd1
added a commit
that referenced
this pull request
Apr 19, 2018
* RW-391 created applicaiton test. * RW-391 attempt at getting @SpringBootTest working. * RW-391 more experimentation. * RW-391 successfuly SpringBootTest! * RW-391 removed unused properties. * RW-391 moved test case to integration. * RW-391 replace with master copy. * Tweak deploy docs and logging (#731) * Js/demo form update (#728) * New "select boxes" * Stylin * Stub in ethnicity * Tests & linting * Small bugfix, more linting * Adding non-standard columns to observation table in CDM schema (#729) * Adding non-standard columns to observation table in CDM schema * Updating comment * Updated README * Refactor detail tab pages to use single page (#733) * Refactor detail tab pages to use single page * Add tab name * Fix "Google Bucket" link (#736) * RW-391 finding a way to programmatically test all beans. * Add ability to run just the tests (#735) * Add ability to run just the tests * Remove unused options * fix for new notebook button being truncated (#738) * Blrubenstein/not found page (#734) * Not Found Page * Fix spacing * PR Comments * Move to better not found pattern. * Fix linting? * Fix sidebar, cohort-review wrapper, persistent scrollbar (#737) * Fix sidebar, cohort-review wrapper, persistent scrollbar * Add comment about height * Clean up PR (#740) * RW-391 * Remove imports, get rid of one getme call (#741) * Remove imports, get rid of one getme call * Make loc public * Add BSD 3-clause LICENSE (#743) * [RW-514] Joining to tables after LIMIT where possible in cohort materialization. (#744) * Start * Fixes * Removing imports * PR comments * Removing log * RW-391 added comments to data.sql and schema.sql and programmtically load beans were interested in testing. * RW-391 cleanup of unused imports. * RW-391 removed unused inserts. * RW-391 removed println. * RW-391 added comment about initializing the database. * RW-391 added maps to list for iteration. * RW-391 created applicaiton test. * RW-391 attempt at getting @SpringBootTest working. * RW-391 more experimentation. * RW-391 successfuly SpringBootTest! * RW-391 removed unused properties. * RW-391 moved test case to integration. * RW-391 replace with master copy. * RW-391 finding a way to programmatically test all beans. * RW-391 * RW-391 added comments to data.sql and schema.sql and programmtically load beans were interested in testing. * RW-391 cleanup of unused imports. * RW-391 removed unused inserts. * RW-391 removed println. * RW-391 added comment about initializing the database. * RW-391 added maps to list for iteration.
SrushtiGangireddy
pushed a commit
that referenced
this pull request
May 30, 2018
SrushtiGangireddy
pushed a commit
that referenced
this pull request
May 30, 2018
* RW-391 created applicaiton test. * RW-391 attempt at getting @SpringBootTest working. * RW-391 more experimentation. * RW-391 successfuly SpringBootTest! * RW-391 removed unused properties. * RW-391 moved test case to integration. * RW-391 replace with master copy. * Tweak deploy docs and logging (#731) * Js/demo form update (#728) * New "select boxes" * Stylin * Stub in ethnicity * Tests & linting * Small bugfix, more linting * Adding non-standard columns to observation table in CDM schema (#729) * Adding non-standard columns to observation table in CDM schema * Updating comment * Updated README * Refactor detail tab pages to use single page (#733) * Refactor detail tab pages to use single page * Add tab name * Fix "Google Bucket" link (#736) * RW-391 finding a way to programmatically test all beans. * Add ability to run just the tests (#735) * Add ability to run just the tests * Remove unused options * fix for new notebook button being truncated (#738) * Blrubenstein/not found page (#734) * Not Found Page * Fix spacing * PR Comments * Move to better not found pattern. * Fix linting? * Fix sidebar, cohort-review wrapper, persistent scrollbar (#737) * Fix sidebar, cohort-review wrapper, persistent scrollbar * Add comment about height * Clean up PR (#740) * RW-391 * Remove imports, get rid of one getme call (#741) * Remove imports, get rid of one getme call * Make loc public * Add BSD 3-clause LICENSE (#743) * [RW-514] Joining to tables after LIMIT where possible in cohort materialization. (#744) * Start * Fixes * Removing imports * PR comments * Removing log * RW-391 added comments to data.sql and schema.sql and programmtically load beans were interested in testing. * RW-391 cleanup of unused imports. * RW-391 removed unused inserts. * RW-391 removed println. * RW-391 added comment about initializing the database. * RW-391 added maps to list for iteration. * RW-391 created applicaiton test. * RW-391 attempt at getting @SpringBootTest working. * RW-391 more experimentation. * RW-391 successfuly SpringBootTest! * RW-391 removed unused properties. * RW-391 moved test case to integration. * RW-391 replace with master copy. * RW-391 finding a way to programmatically test all beans. * RW-391 * RW-391 added comments to data.sql and schema.sql and programmtically load beans were interested in testing. * RW-391 cleanup of unused imports. * RW-391 removed unused inserts. * RW-391 removed println. * RW-391 added comment about initializing the database. * RW-391 added maps to list for iteration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.