Skip to content

Conversation

evrii
Copy link
Collaborator

@evrii evrii commented Aug 5, 2022

The purpose of the PR is to store who made the latest changes to workbench resources. This is done by storing the username of the user to all the resources tables, except notebook

  • The reason why lastModifiedBy is using just username is to have consistency. Since workbench doesn't store notebook information and it can be locked or updated by external users as well. Hence we just use the username for all resources.
  • We could use a user ID for history tracking, which would allow us to enforce data integrity in the database. However, we want this information to persist in the event of deleting a user and our current user deletion process removes them from the database rather than marking the record as deleted.

Description:


PR checklist

  • This PR meets the Acceptance Criteria in the JIRA story
  • The JIRA story has been moved to Dev Review
  • This PR includes appropriate unit tests
  • I have added explanatory comments where the logic is not obvious
  • I have run and tested this change locally, and my testing process is described here
  • If this includes a new feature flag, I have created and linked new JIRA tickets to (a) turn on the feature flag and (b) remove it later
  • If this includes an API change, I have run the E2E tests on this change against my local server with yarn test-local because this PR won't be covered by the CircleCI tests
  • If this includes a UI change, I have taken screen recordings or screenshots of the new behavior and notified the PO and UX designer in Slack
  • If this change impacts deployment safety (e.g. removing/altering APIs which are in use) I have documented these in the description
  • If this includes an API change, I have updated the appropriate Swagger definitions and updated the appropriate API consumers

evrii added 30 commits August 2, 2022 14:35
…to CloudStorageClientImpl. Updated tests accordingly.
@NehaBroad NehaBroad self-assigned this Sep 12, 2022
@NehaBroad NehaBroad requested a review from dmohs September 12, 2022 14:33
@NehaBroad NehaBroad marked this pull request as ready for review September 12, 2022 14:33
@NehaBroad NehaBroad changed the title Eric/last modified by [RW-8497][risk=no]Capture Last Modified User of Artifacts Sep 12, 2022
Copy link
Contributor

@dmohs dmohs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but the PR description should include why we're using the username string instead of a user ID and enforcing data integrity through a foreign key relationship.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants