API Proxy for UI Tests #6927
API Proxy for UI Tests #6927
Conversation
| yarn install | ||
| yarn codegen | ||
| REACT_APP_ENVIRONMENT=pr-site-$PR_SITE_NUM yarn run build --aot --no-watch --no-progress | ||
| REACT_APP_ENVIRONMENT=test yarn run build --aot --no-watch --no-progress |
There was a problem hiding this comment.
If we go with this approach, I will delete the unused PR site configuration files.
| @@ -0,0 +1,19 @@ | |||
| const matchReq = req => req.method === 'OPTIONS' | |||
There was a problem hiding this comment.
This is the only handler that is hand-edited. All of the OPTIONS method responses were basically identical, so I consolidated them into one file.
| @@ -0,0 +1,28 @@ | |||
| import * as nu from 'util' | |||
There was a problem hiding this comment.
Start of non-generated code.
| const create = (logStream = process.stderr) => { | ||
| let lastStamp = -Infinity | ||
|
|
||
| const truncate = ms => Math.floor(ms / 60e3) * 60e3 |
There was a problem hiding this comment.
Codacy says this style of number can be inaccurate. However, (1) I disagree, (2) It wouldn't matter if they were, and (3) I think it is easier to see the value when not crowded with zeros.
There was a problem hiding this comment.
agree that codacy's rule doesn't make sense here
| const create = (logStream = process.stderr) => { | ||
| let lastStamp = -Infinity | ||
|
|
||
| const truncate = ms => Math.floor(ms / 60e3) * 60e3 |
There was a problem hiding this comment.
agree that codacy's rule doesn't make sense here
| req.startTimeMs = Date.now() | ||
| req.index = requestIndex++ | ||
| res.index = req.index | ||
| req.log = (...formatArgs) => { |
There was a problem hiding this comment.
I think you mean the ...formatArgs part, which is just variadic arguments in JS (probably like ES2015+).
There was a problem hiding this comment.
My concern is in in the details of this function: Why does the first arg 'f' get special treatment here?
If I'm interpreting this right, the log command has a mixture of substitution and positional formatting, which could be simplified to log('#%d %s', req.index, f, ...args), in which case I don't see the point of splitting out 'f' at all.
|
|
||
| const quoteSingles = x => x.replace(/[']/g, '\\\'') | ||
| const quoteBackquotes = x => x.replace(/[`]/g, '\\`') | ||
| const formatObj = x => nu.inspect(x, {depth: Infinity, maxArrayLength: 10e3, breakLength: 100}) |
No ticket - Test changes only. No code changes.
This creates a proxy to simulate API responses. The goal is to make UI tests faster and more reliable.
Most of the code is auto-generated from real API responses, so this change is smaller than it looks. You can ignore everything in the
handlersdirectory, provided the code that generates those files looks sound.TODO:
Handlers should not be a set of static files. Instead, each test should define the handlers to be used for that test.