[RW-8020][risk=no] Improve Updated Welcome email #6493
Conversation
|
|
||
| @Test | ||
| public void resendWelcomeEmail_messagingException() throws MessagingException { | ||
| config.access.tiersVisibleToUsers = |
There was a problem hiding this comment.
please add a comment explaining why this is necessary
There was a problem hiding this comment.
please also restore the deprecated versions of these tests
There was a problem hiding this comment.
This functionality will no longer be used as of the next production release, so we decided that the tests do not provide enough utility for the time needed to bring them back.
| } | ||
|
|
||
| @Test | ||
| public void sendUserInstructions_none_deprecated() throws MessagingException { |
There was a problem hiding this comment.
these new tests are not correct. We already have the "deprecated" versions. We need the undeprecated versions.
There was a problem hiding this comment.
also need a "deleted instructions" undeprecated test
There was a problem hiding this comment.
Added a test to handle the un-deprecated case.
| } | ||
|
|
||
| @Test | ||
| public void testSendWelcomeEmail_invalidEmail_RTAndCt() throws MessagingException { |
There was a problem hiding this comment.
Please add local vars to make it clear what these 6 tests are doing.
Like: boolean userHasRt = true
There was a problem hiding this comment.
Decided to not pursue this at this time. If we would like to pursue this convention in the future, we can discuss it.
| <img src="${BULLET_1}"> | ||
| </div> | ||
| </td> | ||
| <td colspan="3"> |
There was a problem hiding this comment.
Bullet and text seems little too far apart for me. I'm curios about colspan="3", not colspan="2".
There was a problem hiding this comment.
I updated the spacing and put a screenshot in the description. What do you think?
8e8bf4f to
a73f372
Compare
a73f372 to
d05254a
Compare
Update Sign Code of Conduct on DAR page
Email:
PR checklist
yarn test-localor yarn test-local-devup