[RW-7893][no risk]lock workspace test #6326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chavanr2019
commented
Feb 14, 2022
aweng98
reviewed
Feb 16, 2022
chavanr2019
commented
Feb 16, 2022
There was a problem hiding this comment.
@jmthibault79 the test steps at line 69-70 have been updated since this file has been refactored: workspace-base.ts
aweng98
suggested changes
Feb 18, 2022
| }); | ||
|
|
||
| // function to create cohort, dataset and notebook | ||
| async function createDatasetNotebook(page: Page, pyNotebookName: string): Promise<NotebookPreviewPage> { |
There was a problem hiding this comment.
This function is same as workspace-admin-ui.spec createDatasetNotebook(). I'm editing it in #6342. You can make this a common function in test-utils.ts.
chavanr2019
commented
Feb 18, 2022
There was a problem hiding this comment.
Will update the requested changes as soon as #6342 is merged. Thanks!
| }); | ||
|
|
||
| // function to create cohort, dataset and notebook | ||
| async function createDatasetNotebook(page: Page, pyNotebookName: string): Promise<NotebookPreviewPage> { |
chavanr2019
commented
Feb 23, 2022
Comment on lines
+478
to
+489
| export async function createDatasetNotebook(page: Page, pyNotebookName: string): Promise<NotebookPreviewPage> { | ||
| await findOrCreateDataset(page, { openEditPage: true }); | ||
|
|
||
| const datasetBuildPage = new DatasetBuildPage(page); | ||
| const exportModal = await datasetBuildPage.clickAnalyzeButton(); | ||
|
|
||
| await exportModal.enterNotebookName(pyNotebookName); | ||
| await exportModal.pickLanguage(Language.Python); | ||
| await exportModal.clickExportButton(); | ||
| const notebookPreviewPage = new NotebookPreviewPage(page); | ||
| return await notebookPreviewPage.waitForLoad(); | ||
| } |
There was a problem hiding this comment.
@aweng98 function moved from the lock-workspace and workspace-admin test file.
Comment on lines
+23
to
+26
| const selected = await getPropValue<string>(element, 'ariaSelected'); | ||
| return selected !== undefined | ||
| ? selected === 'true' | ||
| : (await getStyleValue<string>(this.page, element, 'border-bottom')) !== null; |
There was a problem hiding this comment.
@jmthibault79 tab file updated with the help of Alex, it gets the aria-selected status. Now the tab-status verification works as expected.
aweng98
approved these changes
Feb 23, 2022
e2e/app/page/workspace-about-page.ts
Outdated
| async getLockedWorkspaceReason(): Promise<string> { | ||
| const xpath = '//*[@data-test-id="lock-workspace-msg"]//child::div[2]/div[1]/b'; | ||
| const element = BaseElement.asBaseElement(this.page, await this.page.waitForXPath(xpath, { visible: true })); | ||
| const textContent = element.getTextContent(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEST GOAL
Verify if lock workspace feature works as expected.
PR checklist
yarn test-localor yarn test-local-devup