[risk=no][RW-7280] Enable some Prettier-compatible eslint rules #6199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmthibault79
commented
Jan 24, 2022
| 'prettier', | ||
| 'react', | ||
| 'react-hooks', | ||
| 'simple-import-sort', |
There was a problem hiding this comment.
remove for now; I have a speculative follow-on PR to re-enable.
jmthibault79
commented
Jan 24, 2022
| 'react', | ||
| 'react-hooks', | ||
| 'simple-import-sort', | ||
| 'sort-keys-fix', |
There was a problem hiding this comment.
whatever this was, we no longer refer to it
jmthibault79
commented
Jan 24, 2022
| '@typescript-eslint/prefer-optional-chain': 'warn', | ||
| '@typescript-eslint/unified-signatures': 'warn', | ||
| // '@typescript-eslint/member-ordering': ['warn', { 'classExpressions': ['method', 'field'] }], | ||
| // '@typescript-eslint/prefer-function-type': 'warn', |
There was a problem hiding this comment.
I judged these to be more "functional" than "style" so I moved them to this section
jmthibault79
commented
Jan 24, 2022
|
|
||
| 'prettier/prettier': 'warn', | ||
|
|
||
| 'max-len': [ |
There was a problem hiding this comment.
These 2 are compatible and non-redundant to Prettier
jmthibault79
commented
Jan 24, 2022
|
|
||
| // temp disable others. re-enable if desired after determining that they don't conflict with prettier. | ||
|
|
||
| // 'eol-last': 'warn', |
jmthibault79
commented
Jan 24, 2022
| // 'eol-last': 'warn', | ||
| // 'max-len': ['warn', {code: 140, ignorePattern: '^import |^export\\{(.*?)\\}', ignoreComments: true}], | ||
| // 'no-trailing-spaces': 'warn', | ||
| // 'quotes': ['warn', 'single'], |
jmthibault79
commented
Jan 24, 2022
| // 'max-len': ['warn', {code: 140, ignorePattern: '^import |^export\\{(.*?)\\}', ignoreComments: true}], | ||
| // 'no-trailing-spaces': 'warn', | ||
| // 'quotes': ['warn', 'single'], | ||
| // // 'brace-style': ['warn', '1tbs'], |
jmthibault79
commented
Jan 24, 2022
| // 'no-trailing-spaces': 'warn', | ||
| // 'quotes': ['warn', 'single'], | ||
| // // 'brace-style': ['warn', '1tbs'], | ||
| // // 'no-multi-spaces': 'warn', |
jmthibault79
commented
Jan 24, 2022
| // // '@typescript-eslint/semi': 'warn', | ||
| // | ||
| // 'react/jsx-curly-spacing': ["warn", {'when': 'never'}], | ||
| // 'simple-import-sort/sort': 'warn', |
There was a problem hiding this comment.
deferred- these 2 are bigger changes, and maybe not desirable.
jmthibault79
commented
Jan 24, 2022
| // // 'brace-style': ['warn', '1tbs'], | ||
| // // 'no-multi-spaces': 'warn', | ||
| // // 'simple-import-sort/sort': 'warn', | ||
| // // 'space-before-function-paren': ['warn', { 'anonymous': 'never', 'named': 'never', 'asyncArrow': 'always' }], |
jmthibault79
commented
Jan 24, 2022
| // // 'space-before-function-paren': ['warn', { 'anonymous': 'never', 'named': 'never', 'asyncArrow': 'always' }], | ||
| // // 'spaced-comment': 'warn', | ||
| // | ||
| // '@typescript-eslint/type-annotation-spacing': 'warn', |
jmthibault79
commented
Jan 24, 2022
| // '@typescript-eslint/prefer-function-type': 'warn', | ||
| // // '@typescript-eslint/semi': 'warn', | ||
| // | ||
| // 'react/jsx-curly-spacing': ["warn", {'when': 'never'}], |
jmthibault79
commented
Jan 24, 2022
| if (enablePd) { | ||
| return; | ||
| it( | ||
| 'should set runtime preset values in customize panel instead of getRuntime values ' + |
There was a problem hiding this comment.
line was too long
jmthibault79
commented
Jan 24, 2022
| ); | ||
|
|
||
| it( | ||
| 'should set runtime preset values in customize panel instead of getRuntime values ' + |
There was a problem hiding this comment.
line was too long
jmthibault79
commented
Jan 24, 2022
| CdrVersionsStubVariables.DEFAULT_WORKSPACE_CDR_VERSION_ID | ||
| ); | ||
|
|
||
| const expectedUpgradeMessage = `${CdrVersionsStubVariables.ALT_WORKSPACE_CDR_VERSION} to ${CdrVersionsStubVariables.DEFAULT_WORKSPACE_CDR_VERSION}.`; |
There was a problem hiding this comment.
line too long
jmthibault79
commented
Jan 24, 2022
| }); | ||
|
|
||
| it('should return resource URLs', () => { | ||
| const WORKSPACE_URL_PREFIX = `/workspaces/${WorkspaceStubVariables.DEFAULT_WORKSPACE_NS}/${WorkspaceStubVariables.DEFAULT_WORKSPACE_ID}`; |
There was a problem hiding this comment.
line too long
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some rules are compatible with Prettier, some are incompatible, and some are redundant to it.
PR checklist
yarn test-localor yarn test-local-devup